-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protorev: Use hooks instead of message parsing to trigger backruns #5045
Conversation
- Follows gamm module patterns such as 1) naming convention and 2) providing tokens (sdk.Coins) even though it's currently expected to be a single token in or out (sdk.Coin).
- With new hook based logic, need to persist the swaps to the posthandler. Doing so via storing in kvstored
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you! |
- Also creates a position in the cl pool defined in setupPools
- Limit len(coins) = 1 due to an exit pool message giving all denoms as exitdenoms (and potentially future behavior of other modules)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on expanding the tests! Looks great. I will do a short final pass once all comments are addressed prior to merging
- Panic catching was previously in CompareAndStorePool because that function did the multiplication. - Since then, the multiplication logic that this panic catches overflows on has been separated into it's own function GetComparablePoolLiquidity - This commit moves the panic catching logic to GetComparablePoolLiquidity
This reverts commit ed66bce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work @NotJeremyLiu
What is the purpose of the change
Brief Changelog
Testing and Verifying
Documentation and Release Note